Skip to content
Snippets Groups Projects

qual-sig: Fix URL escaping when fetching the file

Merged Reiter, Christoph requested to merge fix-qual-file-escaping into master

There was a workaround for deriving the filename from the source filename because characters like '#' didn't make it through.

Turns out this was just a bug some lines above where encodeURIComponent() wasn't used as it should.

Use encodeURIComponent() when constructing the URL and remove the workaround.

Merge request reports

Pipeline #15648 passed

Pipeline passed for 180d82a7 on fix-qual-file-escaping

Merged by Reiter, ChristophReiter, Christoph 4 years ago (Jan 12, 2021 1:36pm UTC)

Loading

Pipeline #15650 passed

Pipeline passed for 0da82df4 on master

Deployed to produ‎ction‎ 4 years ago
Deployed to de‎mo‎ 4 years ago
Deployed to devel‎opment‎ 4 years ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading