Skip to content
Snippets Groups Projects
Commit 2053621d authored by Reiter, Christoph's avatar Reiter, Christoph :snake:
Browse files

Move event handling to lit-element and re-enable the loading spinner again

This way lit-element manages the event bindings when the upload component gets
connected.
parent 06c6f8a3
No related branches found
No related tags found
No related merge requests found
...@@ -57,14 +57,6 @@ class OfficialSignaturePdfUpload extends ScopedElementsMixin(VPUSignatureLitElem ...@@ -57,14 +57,6 @@ class OfficialSignaturePdfUpload extends ScopedElementsMixin(VPUSignatureLitElem
connectedCallback() { connectedCallback() {
super.connectedCallback(); super.connectedCallback();
this.updateComplete.then(()=>{
const fileUpload = this._("#file-upload");
fileUpload.addEventListener('vpu-fileupload-all-start', this.onAllUploadStarted.bind(this));
fileUpload.addEventListener('vpu-fileupload-file-start', this.onFileUploadStarted.bind(this));
fileUpload.addEventListener('vpu-fileupload-file-finished', this.onFileUploadFinished.bind(this));
fileUpload.addEventListener('vpu-fileupload-all-finished', this.onAllUploadFinished.bind(this));
});
} }
/** /**
...@@ -294,8 +286,7 @@ class OfficialSignaturePdfUpload extends ScopedElementsMixin(VPUSignatureLitElem ...@@ -294,8 +286,7 @@ class OfficialSignaturePdfUpload extends ScopedElementsMixin(VPUSignatureLitElem
render() { render() {
if (this.isLoading()) { if (this.isLoading()) {
// TODO: breaks upload (added in commit 5dbb3033b4c37ebfb5810d78ed9522047217490d) return html`<vpu-mini-spinner></vpu-mini-spinner>`;
// return html`<vpu-mini-spinner></vpu-mini-spinner>`;
} }
return html` return html`
<div class="${classMap({hidden: !this.isLoggedIn() || !this.hasSignaturePermissions()})}"> <div class="${classMap({hidden: !this.isLoggedIn() || !this.hasSignaturePermissions()})}">
...@@ -303,7 +294,13 @@ class OfficialSignaturePdfUpload extends ScopedElementsMixin(VPUSignatureLitElem ...@@ -303,7 +294,13 @@ class OfficialSignaturePdfUpload extends ScopedElementsMixin(VPUSignatureLitElem
<h2>${i18n.t('official-pdf-upload.upload-field-label')}</h2> <h2>${i18n.t('official-pdf-upload.upload-field-label')}</h2>
<div class="control"> <div class="control">
<vpu-fileupload id="file-upload" lang="${this.lang}" url="${this.signingUrl}" accept="application/pdf" <vpu-fileupload id="file-upload" lang="${this.lang}" url="${this.signingUrl}" accept="application/pdf"
text="${i18n.t('official-pdf-upload.upload-area-text')}" button-label="${i18n.t('official-pdf-upload.upload-button-label')}"></vpu-fileupload> text="${i18n.t('official-pdf-upload.upload-area-text')}"
button-label="${i18n.t('official-pdf-upload.upload-button-label')}"
@vpu-fileupload-all-start="${this.onAllUploadStarted}"
@vpu-fileupload-file-start="${this.onFileUploadStarted}"
@vpu-fileupload-file-finished="${this.onFileUploadFinished}"
@vpu-fileupload-all-finished="${this.onAllUploadFinished}"
></vpu-fileupload>
</div> </div>
</div> </div>
<div class="field notification is-info ${classMap({hidden: !this.uploadInProgress})}"> <div class="field notification is-info ${classMap({hidden: !this.uploadInProgress})}">
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment