Skip to content
Snippets Groups Projects
Commit e897cc29 authored by Reiter, Christoph's avatar Reiter, Christoph :snake:
Browse files

Add test for the demo and fix a typo in disconnect

Also use the same reference for removing the event handler, bind creates a new one.
parent aeb2d871
No related branches found
No related tags found
No related merge requests found
...@@ -6,6 +6,7 @@ class LanguageSelectDemo extends LitElement { ...@@ -6,6 +6,7 @@ class LanguageSelectDemo extends LitElement {
constructor() { constructor() {
super(); super();
this.lang = 'de'; this.lang = 'de';
this.handleChange = this.handleChange.bind(this);
} }
static get properties() { static get properties() {
...@@ -20,11 +21,11 @@ class LanguageSelectDemo extends LitElement { ...@@ -20,11 +21,11 @@ class LanguageSelectDemo extends LitElement {
connectedCallback() { connectedCallback() {
super.connectedCallback(); super.connectedCallback();
window.addEventListener('vpu-language-changed', this.handleChange.bind(this)); window.addEventListener('vpu-language-changed', this.handleChange);
} }
disconnectedCallback() { disconnectedCallback() {
windows.removeEventListener('vpu-language-changed', this.handleChange.bind(this)); window.removeEventListener('vpu-language-changed', this.handleChange);
super.disconnectedCallback(); super.disconnectedCallback();
} }
......
import '../src/language-select'; import '../src/language-select.js';
import '../src/demo.js';
describe('vpu-language-select basics', () => { describe('vpu-language-select basics', () => {
let node; let node;
...@@ -17,3 +18,21 @@ describe('vpu-language-select basics', () => { ...@@ -17,3 +18,21 @@ describe('vpu-language-select basics', () => {
expect(node).to.have.property('shadowRoot'); expect(node).to.have.property('shadowRoot');
}); });
}); });
describe('vpu-language-select demo', () => {
let node;
beforeEach(async () => {
node = document.createElement('vpu-language-select-demo');
document.body.appendChild(node);
await node.updateComplete;
});
afterEach(() => {
node.remove();
});
it('should render', () => {
expect(node).to.have.property('shadowRoot');
});
});
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment