Official Signature: pdf preview and positioning (!1) · Merge requests · digital blueprint / Electronic Signature Service / Signature Frontend · GitLab

Snippets Groups Projects

Gitlab 18.0 has been released. Since there are breaking changes the update will be postponed to July 2025. For a list of breaking changes see https://about.gitlab.com/blog/2025/04/18/a-guide-to-the-breaking-changes-in-gitlab-18-0/. Please prepare yourself and your projects for this update.

This is an archived project. Repository and other project resources are read-only.

Merged Neuber, Eugen Ramon requested to merge official-signature-pdf-preview into master 4 years ago

1 unresolved thread

See issue #12 (closed) and #14 (closed)

Activity

Neuber, Eugen Ramon added Feature label 4 years ago

added Feature label
Bekerle, Patrizio @6123FE4C3B2C2770 4 years ago

Owner

Looks ok to me.
Neuber, Eugen Ramon added 1 commit 4 years ago
added 1 commit

beab15d5 - Hide *Start signing* if signing has already begun

Compare with previous version
Reiter, Christoph @987FCF504483CBC8 started a thread on the diff 4 years ago

src/vpu-pdf-preview.js

             isPageRenderingInProgress: { type: Boolean, attribute: false },
             isPageLoaded: { type: Boolean, attribute: false },
             isShowPlacement: { type: Boolean, attribute: false },
             placeholder: { type: String, attribute: 'signature-placeholder-image' },

Reiter, Christoph @987FCF504483CBC8 4 years ago

Owner

I guess the remaining things are mostly copied, so looks good to me.

Bekerle, Patrizio @6123FE4C3B2C2770 4 years ago

Owner

So beside the rotation (https://gitlab.tugraz.at/VPU/Apps/Signature/-/issues/14#note_13880) and the placeholder attribute it looks good. Should we merge and create issues for those two?

Bekerle, Patrizio merged 4 years ago

merged

Bekerle, Patrizio mentioned in commit 4 years ago

mentioned in commit d314cc63

Bekerle, Patrizio mentioned in issue #14 (closed) 4 years ago

mentioned in issue #14 (closed)

Please register or sign in to reply