From f7b13c20abeb12b7acf543401fa8c0b38c279324 Mon Sep 17 00:00:00 2001
From: Patrizio Bekerle <patrizio.bekerle@tugraz.at>
Date: Tue, 6 Aug 2019 09:33:48 +0200
Subject: [PATCH] Improve multi-language support and add a fix
---
packages/person-select/src/person-select.js | 5 +++--
packages/person-select/src/utils.js | 4 ++++
packages/person-select/vendor/auth | 2 +-
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/packages/person-select/src/person-select.js b/packages/person-select/src/person-select.js
index 099e5c0e..db7eacf4 100644
--- a/packages/person-select/src/person-select.js
+++ b/packages/person-select/src/person-select.js
@@ -26,7 +26,6 @@ class PersonSelect extends VPULitElementJQuery {
connectedCallback() {
super.connectedCallback();
- i18n.changeLanguage(this.lang);
const that = this;
this.updateComplete.then(()=>{
@@ -118,7 +117,7 @@ class PersonSelect extends VPULitElementJQuery {
return $select;
}
- updated(changedProperties) {
+ update(changedProperties) {
changedProperties.forEach((oldValue, propName) => {
if (propName === "lang") {
i18n.changeLanguage(this.lang);
@@ -132,6 +131,8 @@ class PersonSelect extends VPULitElementJQuery {
}
}
});
+
+ super.update(changedProperties);
}
render() {
diff --git a/packages/person-select/src/utils.js b/packages/person-select/src/utils.js
index 3a4386e9..82095b3f 100644
--- a/packages/person-select/src/utils.js
+++ b/packages/person-select/src/utils.js
@@ -25,6 +25,10 @@ module.exports = {
findObjectInApiResults: (identifier, results, identifierAttribute = "@id") => {
const members = results["hydra:member"];
+ if (members === undefined) {
+ return;
+ }
+
for (const object of members){
if (object[identifierAttribute] === identifier) {
return object;
diff --git a/packages/person-select/vendor/auth b/packages/person-select/vendor/auth
index e882180b..c87402ca 160000
--- a/packages/person-select/vendor/auth
+++ b/packages/person-select/vendor/auth
@@ -1 +1 @@
-Subproject commit e882180bbf6dc583894d684a77956249e5179c81
+Subproject commit c87402caad63e6e41359df67857fab394c9d6cd5
--
GitLab