From e1a8d4093292045ad929a2c40c6f29b32dd74b71 Mon Sep 17 00:00:00 2001
From: Christoph Reiter <reiter.christoph@gmail.com>
Date: Thu, 3 Oct 2019 15:45:04 +0200
Subject: [PATCH] Add code splitting and create a main and a demo bundle
---
packages/person-select/assets/index.html | 2 +-
packages/person-select/karma.conf.js | 2 +-
packages/person-select/package.json | 3 ++-
packages/person-select/rollup.config.js | 16 +++++++++++-----
packages/person-select/src/demo.js | 3 +--
packages/person-select/src/index.js | 2 --
...-select-demo.js => vpu-person-select-demo.js} | 3 ++-
.../{person-select.js => vpu-person-select.js} | 0
packages/person-select/test/unit.js | 4 ++--
9 files changed, 20 insertions(+), 15 deletions(-)
delete mode 100644 packages/person-select/src/index.js
rename packages/person-select/src/{person-select-demo.js => vpu-person-select-demo.js} (97%)
rename packages/person-select/src/{person-select.js => vpu-person-select.js} (100%)
diff --git a/packages/person-select/assets/index.html b/packages/person-select/assets/index.html
index 07aa8818..4db26ed3 100644
--- a/packages/person-select/assets/index.html
+++ b/packages/person-select/assets/index.html
@@ -2,7 +2,7 @@
<html>
<head>
<meta charset="UTF-8">
- <script type="module" id="vpu-person-select-src" src="vpu-person-select.js"></script>
+ <script type="module" id="vpu-person-select-src" src="vpu-person-select-demo.js"></script>
</head>
<body>
diff --git a/packages/person-select/karma.conf.js b/packages/person-select/karma.conf.js
index 3a47e54d..4b99e08a 100644
--- a/packages/person-select/karma.conf.js
+++ b/packages/person-select/karma.conf.js
@@ -7,7 +7,7 @@ module.exports = function(config) {
basePath: 'dist',
frameworks: ['mocha', 'chai'],
files: [
- {pattern: './' + pkg.name + '.js', included: true, watched: true, served: true, type: 'module'},
+ {pattern: './*.js', included: true, watched: true, served: true, type: 'module'},
{pattern: './**/*', included: false, watched: true, served: true},
],
autoWatch: true,
diff --git a/packages/person-select/package.json b/packages/person-select/package.json
index d5053d5f..a3673add 100644
--- a/packages/person-select/package.json
+++ b/packages/person-select/package.json
@@ -1,7 +1,7 @@
{
"name": "vpu-person-select",
"version": "1.0.0",
- "main": "src/index.js",
+ "main": "src/vpu-person-select.js",
"devDependencies": {
"chai": "^4.2.0",
"i18next-scanner": "^2.10.2",
@@ -22,6 +22,7 @@
"rollup-plugin-serve": "^1.0.1",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-url": "^2.2.2",
+ "rollup-plugin-delete": "^1.1.0",
"vpu-auth": "file:./vendor/auth",
"vpu-common": "file:./vendor/common"
},
diff --git a/packages/person-select/rollup.config.js b/packages/person-select/rollup.config.js
index 9a2dcb51..a5adb068 100644
--- a/packages/person-select/rollup.config.js
+++ b/packages/person-select/rollup.config.js
@@ -8,19 +8,25 @@ import serve from 'rollup-plugin-serve';
import multiEntry from 'rollup-plugin-multi-entry';
import url from "rollup-plugin-url"
import consts from 'rollup-plugin-consts';
+import del from 'rollup-plugin-delete';
-const pkg = require('./package.json');
const build = (typeof process.env.BUILD !== 'undefined') ? process.env.BUILD : 'local';
console.log("build: " + build);
export default {
- input: (build != 'test') ? 'src/demo.js' : 'test/**/*.js',
+ input: (build != 'test') ? ['src/vpu-person-select.js', 'src/vpu-person-select-demo.js'] : 'test/**/*.js',
output: {
- file: 'dist/' + pkg.name + '.js',
- format: 'esm'
+ dir: 'dist',
+ entryFileNames: '[name].js',
+ chunkFileNames: 'shared/[name].[hash].[format].js',
+ format: 'esm',
+ sourcemap: true
},
plugins: [
- multiEntry(),
+ del({
+ targets: 'dist/*'
+ }),
+ (build == 'test') ? multiEntry() : false,
consts({
environment: build,
}),
diff --git a/packages/person-select/src/demo.js b/packages/person-select/src/demo.js
index 46db4c06..57828ac3 100644
--- a/packages/person-select/src/demo.js
+++ b/packages/person-select/src/demo.js
@@ -1,2 +1 @@
-import 'vpu-auth';
-import './person-select-demo.js';
+import './vpu-person-select-demo.js';
diff --git a/packages/person-select/src/index.js b/packages/person-select/src/index.js
deleted file mode 100644
index e1cff7b4..00000000
--- a/packages/person-select/src/index.js
+++ /dev/null
@@ -1,2 +0,0 @@
-import 'vpu-auth';
-import './person-select.js';
diff --git a/packages/person-select/src/person-select-demo.js b/packages/person-select/src/vpu-person-select-demo.js
similarity index 97%
rename from packages/person-select/src/person-select-demo.js
rename to packages/person-select/src/vpu-person-select-demo.js
index b7311b4e..8b9fcb7f 100644
--- a/packages/person-select/src/person-select-demo.js
+++ b/packages/person-select/src/vpu-person-select-demo.js
@@ -1,6 +1,7 @@
+import 'vpu-auth';
import {i18n} from './i18n.js';
import {css, html, LitElement} from 'lit-element';
-import './person-select.js';
+import './vpu-person-select.js';
import * as commonUtils from 'vpu-common/utils';
import bulmaCSSPath from "bulma/css/bulma.min.css";
diff --git a/packages/person-select/src/person-select.js b/packages/person-select/src/vpu-person-select.js
similarity index 100%
rename from packages/person-select/src/person-select.js
rename to packages/person-select/src/vpu-person-select.js
diff --git a/packages/person-select/test/unit.js b/packages/person-select/test/unit.js
index e396c5ea..d09cf476 100644
--- a/packages/person-select/test/unit.js
+++ b/packages/person-select/test/unit.js
@@ -1,5 +1,5 @@
-import '../src/person-select';
-import '../src/demo';
+import '../src/vpu-person-select.js';
+import '../src/demo.js';
describe('vpu-person-select basics', () => {
let node;
--
GitLab