From cd6535b80b26f9756dccf943757ab69c7473bc13 Mon Sep 17 00:00:00 2001
From: Christoph Reiter <reiter.christoph@gmail.com>
Date: Thu, 1 Aug 2019 11:33:04 +0200
Subject: [PATCH] Include vendored packages in package.json directly
---
packages/notification/.gitlab-ci.yml | 1 -
packages/notification/README.md | 6 +-----
packages/notification/package.json | 6 +++---
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/packages/notification/.gitlab-ci.yml b/packages/notification/.gitlab-ci.yml
index 39843120..e7b6c123 100644
--- a/packages/notification/.gitlab-ci.yml
+++ b/packages/notification/.gitlab-ci.yml
@@ -15,6 +15,5 @@ test:
script:
- apt update
- apt install -y npm
- - npm run setup
- npm install
- npm run build
diff --git a/packages/notification/README.md b/packages/notification/README.md
index 1d6f86fd..65ed4e0f 100644
--- a/packages/notification/README.md
+++ b/packages/notification/README.md
@@ -34,11 +34,7 @@ git clone git@gitlab.tugraz.at:VPU/WebComponents/Notification.git
cd Notification
git submodule update --init
-# we are creating the symbolic links to our git sub-modules
-# (there was no proper script to do this automatically before a "node install"
-npm run setup
-
-# install dependencies
+# install dependencies (make sure you have npm version 4+ installed, so symlinks to the git submodules are created automatically)
npm install
# constantly build dist/bundle.js and run a local web-server on port 8002
diff --git a/packages/notification/package.json b/packages/notification/package.json
index e12745db..d10ab112 100644
--- a/packages/notification/package.json
+++ b/packages/notification/package.json
@@ -13,13 +13,13 @@
"rollup-plugin-terser": "^4.0.4",
"rollup-plugin-json": "^4.0.0",
"rollup-plugin-replace": "^2.2.0",
- "i18next-scanner": "^2.10.2"
+ "i18next-scanner": "^2.10.2",
+ "vpu-common": "file:./vendor/common"
},
"dependencies": {
"@webcomponents/webcomponentsjs": "^2.2.10",
"i18next": "^17.0.3",
- "lit-element": "^2.1.0",
- "vpu-common": "*"
+ "lit-element": "^2.1.0"
},
"scripts": {
"setup": "mkdir -p node_modules && cd node_modules && ln -sfn ../vendor/common vpu-common",
--
GitLab