From c341cf9eefdb7791db8f4d41e99c63903dc4562f Mon Sep 17 00:00:00 2001
From: Eugen Neuber <eugen.neuber@tugraz.at>
Date: Mon, 18 Jan 2021 10:54:35 +0100
Subject: [PATCH] Change property check to `this.hasOwnproperty(name)`
(check for `this[name]` failed for value `false`)
---
packages/provider/src/provider.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/packages/provider/src/provider.js b/packages/provider/src/provider.js
index 41611ca3..1f2f32ff 100644
--- a/packages/provider/src/provider.js
+++ b/packages/provider/src/provider.js
@@ -14,7 +14,7 @@ export class Provider extends HTMLElement {
this.addEventListener('subscribe', function (e) {
const name = e.detail.name;
- if (that[name] || that.root) {
+ if (that.hasOwnProperty(name) || that.root) {
console.log('Provider(' + that.id + ') eventListener("subscribe",..) name "' + name + '" found.');
that.callbackStore.push({name: name, callback: e.detail.callback, sender: e.detail.sender});
@@ -26,7 +26,7 @@ export class Provider extends HTMLElement {
this.addEventListener('unsubscribe', function (e) {
const name = e.detail.name;
const sender = e.detail.sender;
- if (that[name] || that.root) {
+ if (that.hasOwnProperty(name) || that.root) {
console.log('Provider(' + that.id + ') eventListener("unsubscribe",..) name "' + name + '" found.');
that.callbackStore.forEach(item => {
if (item.sender === sender && item.name === name) {
@@ -45,7 +45,7 @@ export class Provider extends HTMLElement {
const name = e.detail.name;
const value = e.detail.value;
- if (that[name] || that.root) {
+ if (that.hasOwnProperty(name) || that.root) {
console.log('Provider(' + that.id + ') eventListener("set-property",..) name "' + name + '" found.');
that[name] = value;
--
GitLab