From bb23a2b5cbd3cd277dfcd7f4feb3270303af5eae Mon Sep 17 00:00:00 2001 From: Christoph Reiter <reiter.christoph@gmail.com> Date: Thu, 3 Oct 2019 14:06:30 +0200 Subject: [PATCH] Port to use code splitting; Rename entry point to the package name --- packages/person-profile/assets/index.html | 2 +- .../assets/vpu-person-profile.metadata.json | 2 +- packages/person-profile/package.json | 2 +- packages/person-profile/rollup.config.js | 12 ++++++++---- packages/person-profile/src/demo.js | 3 +-- packages/person-profile/src/index.js | 1 - ...on-profile-demo.js => vpu-person-profile-demo.js} | 3 ++- .../src/{person-profile.js => vpu-person-profile.js} | 0 packages/person-profile/test/unit.js | 2 +- 9 files changed, 15 insertions(+), 12 deletions(-) delete mode 100644 packages/person-profile/src/index.js rename packages/person-profile/src/{person-profile-demo.js => vpu-person-profile-demo.js} (98%) rename packages/person-profile/src/{person-profile.js => vpu-person-profile.js} (100%) diff --git a/packages/person-profile/assets/index.html b/packages/person-profile/assets/index.html index 20337958..29e3d858 100644 --- a/packages/person-profile/assets/index.html +++ b/packages/person-profile/assets/index.html @@ -2,7 +2,7 @@ <html> <head> <meta charset="UTF-8"> - <script type="module" src="bundle.js"></script> + <script type="module" src="vpu-person-profile-demo.js"></script> </head> <body> diff --git a/packages/person-profile/assets/vpu-person-profile.metadata.json b/packages/person-profile/assets/vpu-person-profile.metadata.json index 3d9ab2f7..b9e00c25 100644 --- a/packages/person-profile/assets/vpu-person-profile.metadata.json +++ b/packages/person-profile/assets/vpu-person-profile.metadata.json @@ -1,6 +1,6 @@ { "element": "vpu-person-profile", - "module_src": "person-profile.js", + "module_src": "vpu-person-profile.js", "name": { "de": "Benutzerprofil", "en": "User profile" diff --git a/packages/person-profile/package.json b/packages/person-profile/package.json index f31ed47d..4c56323c 100644 --- a/packages/person-profile/package.json +++ b/packages/person-profile/package.json @@ -1,7 +1,7 @@ { "name": "vpu-person-profile", "version": "1.0.0", - "main": "src/index.js", + "main": "src/vpu-person-profile.js", "devDependencies": { "karma": "^4.2.0", "karma-chai": "^0.1.0", diff --git a/packages/person-profile/rollup.config.js b/packages/person-profile/rollup.config.js index d170616d..de4e11e1 100644 --- a/packages/person-profile/rollup.config.js +++ b/packages/person-profile/rollup.config.js @@ -14,16 +14,19 @@ const build = (typeof process.env.BUILD !== 'undefined') ? process.env.BUILD : ' console.log("build: " + build); export default { - input: (build != 'test') ? 'src/demo.js' : 'test/**/*.js', + input: (build != 'test') ? ['src/vpu-person-profile.js', 'src/vpu-person-profile-demo.js'] : 'test/**/*.js', output: { - file: 'dist/bundle.js', - format: 'esm' + dir: 'dist', + entryFileNames: '[name].js', + chunkFileNames: 'shared/[name].[hash].[format].js', + format: 'esm', + sourcemap: true }, plugins: [ del({ targets: 'dist/*' }), - multiEntry(), + (build == 'test') ? multiEntry() : false, consts({ environment: build, }), @@ -51,6 +54,7 @@ export default { copy({ targets: [ {src: 'assets/index.html', dest: 'dist'}, + {src: 'assets/vpu-person-profile.metadata.json', dest: 'dist'}, {src: 'node_modules/vpu-common/assets/icons/*.svg', dest: 'dist/local/vpu-common/icons'}, ], }), diff --git a/packages/person-profile/src/demo.js b/packages/person-profile/src/demo.js index 01e0c43a..c89a0e17 100644 --- a/packages/person-profile/src/demo.js +++ b/packages/person-profile/src/demo.js @@ -1,2 +1 @@ -import 'vpu-auth'; -import './person-profile-demo.js'; +import './vpu-person-profile-demo.js'; diff --git a/packages/person-profile/src/index.js b/packages/person-profile/src/index.js deleted file mode 100644 index ac6be2e8..00000000 --- a/packages/person-profile/src/index.js +++ /dev/null @@ -1 +0,0 @@ -import './person-profile.js'; diff --git a/packages/person-profile/src/person-profile-demo.js b/packages/person-profile/src/vpu-person-profile-demo.js similarity index 98% rename from packages/person-profile/src/person-profile-demo.js rename to packages/person-profile/src/vpu-person-profile-demo.js index cd026c21..b5e7452b 100644 --- a/packages/person-profile/src/person-profile-demo.js +++ b/packages/person-profile/src/vpu-person-profile-demo.js @@ -1,7 +1,8 @@ +import 'vpu-auth'; import {i18n} from './i18n.js'; import {css, html, LitElement} from 'lit-element'; import VPULitElement from 'vpu-common/vpu-lit-element'; -import './person-profile.js'; +import './vpu-person-profile.js'; import * as commonUtils from 'vpu-common/utils'; import bulmaCSSPath from "bulma/css/bulma.min.css"; import $ from 'jquery'; diff --git a/packages/person-profile/src/person-profile.js b/packages/person-profile/src/vpu-person-profile.js similarity index 100% rename from packages/person-profile/src/person-profile.js rename to packages/person-profile/src/vpu-person-profile.js diff --git a/packages/person-profile/test/unit.js b/packages/person-profile/test/unit.js index 102c83a2..9c4ca04e 100644 --- a/packages/person-profile/test/unit.js +++ b/packages/person-profile/test/unit.js @@ -1,4 +1,4 @@ -import '../src/person-profile.js'; +import '../src/vpu-person-profile.js'; import '../src/demo.js'; describe('vpu-person-profile demo', () => { -- GitLab