diff --git a/packages/person-select/.eslintignore b/packages/person-select/.eslintignore new file mode 100644 index 0000000000000000000000000000000000000000..7b596da7b5a30a2b742e9bc9bc8002606940e18a --- /dev/null +++ b/packages/person-select/.eslintignore @@ -0,0 +1,3 @@ +/vendor/** +/dist/** +/*.js \ No newline at end of file diff --git a/packages/person-select/.eslintrc.json b/packages/person-select/.eslintrc.json new file mode 100644 index 0000000000000000000000000000000000000000..1ccd30a3fee0b4867a0172e746714eb0083fb07d --- /dev/null +++ b/packages/person-select/.eslintrc.json @@ -0,0 +1,25 @@ +{ + "env": { + "browser": true, + "es6": true, + "mocha": true + }, + "extends": ["eslint:recommended", "plugin:jsdoc/recommended"], + "globals": { + "Atomics": "readonly", + "SharedArrayBuffer": "readonly" + }, + "parser": "babel-eslint", + "parserOptions": { + "ecmaVersion": 2018, + "sourceType": "module" + }, + "rules": { + "no-unused-vars": ["error", { "args": "none" }], + "semi": [2, "always"], + "jsdoc/require-jsdoc": 0, + "jsdoc/require-param-description": 0, + "jsdoc/require-returns": 0, + "jsdoc/require-param-type": 0 + } +} \ No newline at end of file diff --git a/packages/person-select/package.json b/packages/person-select/package.json index d7d3c8150938510547fb24560490e555b9ea1100..cb983e55d499e4682a262ea7a1422b75500be53f 100644 --- a/packages/person-select/package.json +++ b/packages/person-select/package.json @@ -31,7 +31,9 @@ "rollup-plugin-copy": "^3.1.0", "rollup-plugin-delete": "^2.0.0", "rollup-plugin-serve": "^1.0.1", - "rollup-plugin-terser": "^7.0.2" + "rollup-plugin-terser": "^7.0.2", + "eslint": "^7.3.1", + "eslint-plugin-jsdoc": "^30.6.4" }, "dependencies": { "@dbp-toolkit/auth": "^0.1.0", @@ -53,6 +55,7 @@ "watch": "npm run watch-local", "watch-local": "rollup -c --watch", "watch-dev": "rollup -c --watch --environment BUILD:development", - "test": "npm run build-test && karma start --singleRun" + "test": "npm run build-test && karma start --singleRun", + "lint": "eslint ." } } diff --git a/packages/person-select/src/i18n/de/select2.js b/packages/person-select/src/i18n/de/select2.js index 487734d315bddea78931e81907b44033bceb504e..bef156f0f506c91c494fa5fc1c7a7b49a8a97d9c 100644 --- a/packages/person-select/src/i18n/de/select2.js +++ b/packages/person-select/src/i18n/de/select2.js @@ -43,4 +43,4 @@ export default function () { return 'Entferne alle Gegenstände'; } }; -}; +} diff --git a/packages/person-select/src/i18n/en/select2.js b/packages/person-select/src/i18n/en/select2.js index 12ba14cc3c6a8af6a9c24a7366aef7ca739f3509..d172d72ef06e17651dda4d2f6d73ef49e50cf845 100644 --- a/packages/person-select/src/i18n/en/select2.js +++ b/packages/person-select/src/i18n/en/select2.js @@ -47,4 +47,4 @@ export default function () { return 'Remove all items'; } }; -}; +} diff --git a/packages/person-select/src/person-select.js b/packages/person-select/src/person-select.js index d91dd9ce2e0e5df55227f6cc19dcb756638a3a82..91bd3d52248b307b12aab807c025fc7592afdeb3 100644 --- a/packages/person-select/src/person-select.js +++ b/packages/person-select/src/person-select.js @@ -1,8 +1,8 @@ import $ from 'jquery'; import {findObjectInApiResults} from './utils.js'; import select2 from 'select2'; -import select2LangDe from './i18n/de/select2' -import select2LangEn from './i18n/en/select2' +import select2LangDe from './i18n/de/select2'; +import select2LangEn from './i18n/en/select2'; import JSONLD from '@dbp-toolkit/common/jsonld'; import {css, html, LitElement} from 'lit-element'; import {ScopedElementsMixin} from '@open-wc/scoped-elements'; @@ -115,6 +115,8 @@ export class PersonSelect extends ScopedElementsMixin(LitElement) { /** * Initializes the Select2 selector + * + * @param ignorePreset */ initSelect2(ignorePreset = false) { const that = this;