From b95f505ab279efe3bae95b7cd74bd6444dc38720 Mon Sep 17 00:00:00 2001
From: Christoph Reiter <reiter.christoph@gmail.com>
Date: Tue, 6 Aug 2019 13:12:23 +0200
Subject: [PATCH] Use utils.defineCustomElement() for defining our custom
elements
So we get errors with older browsers.
---
packages/language-select/.gitmodules | 3 +++
packages/language-select/package.json | 3 ++-
packages/language-select/src/demo.js | 3 ++-
packages/language-select/src/language-select.js | 3 ++-
packages/language-select/vendor/common | 1 +
5 files changed, 10 insertions(+), 3 deletions(-)
create mode 160000 packages/language-select/vendor/common
diff --git a/packages/language-select/.gitmodules b/packages/language-select/.gitmodules
index e69de29b..d423707d 100644
--- a/packages/language-select/.gitmodules
+++ b/packages/language-select/.gitmodules
@@ -0,0 +1,3 @@
+[submodule "vendor/common"]
+ path = vendor/common
+ url = git@gitlab.tugraz.at:VPU/WebComponents/Common.git
diff --git a/packages/language-select/package.json b/packages/language-select/package.json
index 7e309b9f..5bdcefba 100644
--- a/packages/language-select/package.json
+++ b/packages/language-select/package.json
@@ -20,7 +20,8 @@
"rollup-plugin-json": "^4.0.0",
"rollup-plugin-replace": "^2.2.0",
"rollup-plugin-multi-entry": "^2.1.0",
- "i18next-scanner": "^2.10.2"
+ "i18next-scanner": "^2.10.2",
+ "vpu-common": "file:./vendor/common"
},
"dependencies": {
"i18next": "^17.0.3",
diff --git a/packages/language-select/src/demo.js b/packages/language-select/src/demo.js
index dc7b9642..1586526b 100644
--- a/packages/language-select/src/demo.js
+++ b/packages/language-select/src/demo.js
@@ -1,5 +1,6 @@
import {html, LitElement} from 'lit-element';
import './language-select.js';
+import utils from 'vpu-common/utils';
class LanguageSelectDemo extends LitElement {
@@ -34,4 +35,4 @@ class LanguageSelectDemo extends LitElement {
}
}
-customElements.define('vpu-language-select-demo', LanguageSelectDemo);
+utils.defineCustomElement('vpu-language-select-demo', LanguageSelectDemo);
diff --git a/packages/language-select/src/language-select.js b/packages/language-select/src/language-select.js
index 79da8a0c..cf3a5102 100644
--- a/packages/language-select/src/language-select.js
+++ b/packages/language-select/src/language-select.js
@@ -1,5 +1,6 @@
import {html, css, LitElement} from 'lit-element';
import {i18n, dateTimeFormat, numberFormat} from './i18n.js';
+import utils from 'vpu-common/utils';
/**
* Emits a vpu-language-changed event where event.detail.lang is the new selected language
@@ -99,4 +100,4 @@ class LanguageSelect extends LitElement {
}
}
-customElements.define('vpu-language-select', LanguageSelect);
+utils.defineCustomElement('vpu-language-select', LanguageSelect);
diff --git a/packages/language-select/vendor/common b/packages/language-select/vendor/common
new file mode 160000
index 00000000..675c681d
--- /dev/null
+++ b/packages/language-select/vendor/common
@@ -0,0 +1 @@
+Subproject commit 675c681d7038cce98bbd03fa8483055dd8ef9406
--
GitLab