From 9ac3c01a29bef0e865d5a5c74510056efe13509e Mon Sep 17 00:00:00 2001
From: Eugen Neuber <eugen.neuber@tugraz.at>
Date: Wed, 13 Jan 2021 10:28:11 +0100
Subject: [PATCH] Remove init attribute

Set init key/values like an other attributes: key="value"
---
 packages/provider/src/dbp-provider-demo.js | 13 ++++----
 packages/provider/src/provider.js          | 35 ----------------------
 2 files changed, 7 insertions(+), 41 deletions(-)

diff --git a/packages/provider/src/dbp-provider-demo.js b/packages/provider/src/dbp-provider-demo.js
index 180a9d63..7d337e8b 100644
--- a/packages/provider/src/dbp-provider-demo.js
+++ b/packages/provider/src/dbp-provider-demo.js
@@ -49,12 +49,12 @@ class ProviderDemo extends ScopedElementsMixin(LitElement) {
     render() {
         return html`
             <dbp-provider id="root"
-                          init="availability=global"
                           blah="777"
+                          availability="global"
             ><section class="section">
                 <p>Provider <em>"root"</em> is the top most in hierarchy:</p>
 <pre>
-&lt;dbp-provider  id="root"  init="availability=global" >&lt;/dbp-provider&gt;
+&lt;dbp-provider  id="root"  availability="global" >&lt;/dbp-provider&gt;
 </pre>
                 <div class="container">
                     <h1 class="title">Provider-Demo</h1>
@@ -64,20 +64,21 @@ class ProviderDemo extends ScopedElementsMixin(LitElement) {
                     <dbp-login-button lang="${this.lang}" show-image></dbp-login-button>
                 </div>
                 <dbp-provider id="demo"
-                              init="bc=blue"
+                              bc="blue"
                 >
                     <dbp-provider id="foo-bar"
-                                  init="foo=9,bar=20"
+                                  foo="9"
+                                  bar="20"
                 >
                     <div class="container">
                     <h2>Provider</h2>
                     <p>Provider <em>"demo"</em> has only <em>border-color</em> to offer:</p>
 <pre>
-&lt;dbp-provider  id="demo"  init="bc=blue" &gt;&lt;/dbp-provider&gt;
+&lt;dbp-provider  id="demo"  bc="blue" &gt;&lt;/dbp-provider&gt;
 </pre>
                     <p>Provider <em>"foo-bar"</em> has some values in its store:</p>
 <pre>
-&lt;dbp-provider  id="foo-bar"  init="foo=9,bar=20" &gt;&lt;/dbp-provider&gt;
+&lt;dbp-provider  id="foo-bar"  foo="9" bar="20" &gt;&lt;/dbp-provider&gt;
 </pre>
                     <h2>Consumer</h2>
                     <p>Consumer <em>"c1"</em> will only subscribe to <em>border-color</em></p>
diff --git a/packages/provider/src/provider.js b/packages/provider/src/provider.js
index 297236c0..342d59f3 100644
--- a/packages/provider/src/provider.js
+++ b/packages/provider/src/provider.js
@@ -6,38 +6,6 @@ export class Provider extends HTMLElement {
         console.log('Provider constructor()');
     }
 
-    static get observedAttributes() {
-        return ['init'];
-    }
-
-    attributeChangedCallback(name, oldValue, newValue) {
-        console.log('Provider(' + this.id() + ') attribute "' + name + '" changed from "' + oldValue + '" to "' + newValue + '".');
-        switch(name) {
-            case 'init':
-                this.init = newValue;
-                if (newValue) {
-                    const attrs = newValue.split(',');
-                    attrs.forEach(element => {
-                        const pair = element.trim().split('=');
-                        const name = pair[0].trim();
-                        const value = pair[1].trim().replace('"', '').replace("'", '');
-                        if (name.length > 0) {
-                            this[name] = value;
-                            this.callbackStore.forEach(item => {
-                                if (item.name === name) {
-                                    item.callback(value);
-                                }
-                            });
-                        }
-                    });
-                }
-                break;
-            default:
-                console.log('unknown attribute "' + name + '".');
-        }
-    }
-
-
     connectedCallback() {
         console.log('Provider(' + this.id() + ') connectedCallback()');
 
@@ -131,9 +99,6 @@ export class Provider extends HTMLElement {
                 if (['id', 'class', 'style', 'data-tag-name'].includes(attrs[i].name)) {
                     continue;
                 }
-                if (Provider.observedAttributes.includes(attrs[i].name)) {
-                    continue;
-                }
 
                 this[attrs[i].name] = attrs[i].value;
                 console.log('Provider (' + that.id() + ') found attribute "' + attrs[i].name + '" = "' + attrs[i].value + '"');
-- 
GitLab