From 895589a680d8ba5ba4618ea00edc3f0f7f07962b Mon Sep 17 00:00:00 2001
From: Christoph Reiter <reiter.christoph@gmail.com>
Date: Wed, 11 Nov 2020 12:19:44 +0100
Subject: [PATCH] LoadingButton: allow setting the label via the main slot
More in line with native button elements
---
packages/common/src/button.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/packages/common/src/button.js b/packages/common/src/button.js
index 28c24192..1ba86734 100644
--- a/packages/common/src/button.js
+++ b/packages/common/src/button.js
@@ -98,6 +98,7 @@ export class LoadingButton extends ScopedElementsMixin(LitElement) {
static get properties() {
return {
+ // value is deprecated, use the main slot instead
value: { type: String },
type: { type: String },
loading: { type: Boolean },
@@ -155,7 +156,7 @@ export class LoadingButton extends ScopedElementsMixin(LitElement) {
render() {
return html`
<button class="button ${this.type} loading-container ${!this.loading ? "is-not-loading" : ""}" ?disabled="${this.disabled}">
- <div class="label">${this.value}</div> <dbp-mini-spinner class="spinner" style="display: ${this.loading ? "inline" : "none"}"></dbp-mini-spinner>
+ <div class="label"><slot>${this.value}</slot></div> <dbp-mini-spinner class="spinner" style="display: ${this.loading ? "inline" : "none"}"></dbp-mini-spinner>
</button>
`;
}
--
GitLab