From 800a3256ff2e804143a8926f42d229abda9ebdd6 Mon Sep 17 00:00:00 2001
From: Patrizio Bekerle <patrizio.bekerle@tugraz.at>
Date: Thu, 17 Oct 2019 10:56:21 +0200
Subject: [PATCH] Remove Bulma dependency
---
packages/person-profile/package.json | 1 -
.../person-profile/src/vpu-person-profile-demo.js | 9 +++++----
packages/person-profile/src/vpu-person-profile.js | 14 ++++++++++----
3 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/packages/person-profile/package.json b/packages/person-profile/package.json
index 4c56323c..8fbb7008 100644
--- a/packages/person-profile/package.json
+++ b/packages/person-profile/package.json
@@ -28,7 +28,6 @@
"vpu-person-select": "file:./vendor/person-select"
},
"dependencies": {
- "bulma": "^0.7.5",
"lit-element": "^2.2.1",
"jquery": "^3.4.1"
},
diff --git a/packages/person-profile/src/vpu-person-profile-demo.js b/packages/person-profile/src/vpu-person-profile-demo.js
index b5e7452b..1b63722f 100644
--- a/packages/person-profile/src/vpu-person-profile-demo.js
+++ b/packages/person-profile/src/vpu-person-profile-demo.js
@@ -4,7 +4,7 @@ import {css, html, LitElement} from 'lit-element';
import VPULitElement from 'vpu-common/vpu-lit-element';
import './vpu-person-profile.js';
import * as commonUtils from 'vpu-common/utils';
-import bulmaCSSPath from "bulma/css/bulma.min.css";
+import * as commonStyles from 'vpu-common/styles';
import $ from 'jquery';
import 'vpu-person-select';
@@ -47,6 +47,9 @@ class PersonProfileDemo extends VPULitElement {
static get styles() {
// language=css
return css`
+ ${commonStyles.getThemeCSS()}
+ ${commonStyles.getGeneralCSS()}
+
h1.title {margin-bottom: 1em;}
div.container {margin-bottom: 1.5em;}
`;
@@ -64,10 +67,8 @@ class PersonProfileDemo extends VPULitElement {
render() {
commonUtils.initAssetBaseURL('vpu-person-profile-src');
- const bulmaCSS = commonUtils.getAssetURL(bulmaCSSPath);
- return html`
- <link rel="stylesheet" href="${bulmaCSS}">
+ return html`
${this.getAuthComponentHtml()}
<section class="section">
diff --git a/packages/person-profile/src/vpu-person-profile.js b/packages/person-profile/src/vpu-person-profile.js
index 434d3dd3..74f98159 100644
--- a/packages/person-profile/src/vpu-person-profile.js
+++ b/packages/person-profile/src/vpu-person-profile.js
@@ -1,10 +1,10 @@
import JSONLD from 'vpu-common/jsonld';
-import {html} from 'lit-element';
+import {css, html} from 'lit-element';
import {i18n} from './i18n.js';
import VPULitElement from 'vpu-common/vpu-lit-element';
import * as commonUtils from 'vpu-common/utils';
-import bulmaCSSPath from "bulma/css/bulma.min.css";
+import * as commonStyles from 'vpu-common/styles';
class PersonProfile extends VPULitElement {
@@ -72,6 +72,14 @@ class PersonProfile extends VPULitElement {
super.update(changedProperties);
}
+ static get styles() {
+ // language=css
+ return css`
+ ${commonStyles.getThemeCSS()}
+ ${commonStyles.getGeneralCSS()}
+ `;
+ }
+
render() {
let role = i18n.t('person-profile.unknown');
if (this.person !== null && this.person.roles !== undefined) {
@@ -83,9 +91,7 @@ class PersonProfile extends VPULitElement {
}
}
commonUtils.initAssetBaseURL('vpu-person-profile-src');
- const bulmaCSS = commonUtils.getAssetURL(bulmaCSSPath);
return html`
- <link rel="stylesheet" href="${bulmaCSS}">
<style>
.profile {
padding: 1rem
--
GitLab