From 780da142a2c952e7306fe148677b0fbd6f69957e Mon Sep 17 00:00:00 2001
From: Patrizio Bekerle <patrizio@bekerle.com>
Date: Thu, 10 Jun 2021 14:39:06 +0200
Subject: [PATCH] Set default app shell name and remove shell-name and
shell-subname attributes
---
packages/app-shell/README.md | 4 ----
packages/app-shell/src/app-shell.js | 6 +-----
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/packages/app-shell/README.md b/packages/app-shell/README.md
index 634d1634..7c38fb6a 100644
--- a/packages/app-shell/README.md
+++ b/packages/app-shell/README.md
@@ -30,10 +30,6 @@ npm i @dbp-toolkit/app-shell
- example `<dbp-app-shell matomo-site-id="456789"></dbp-app-shell>`
- `no-welcome-page` (optional): skips the welcome page and welcome page isn't visible in menu
- example `<dbp-app-shell no-welcome-page></dbp-app-shell>`
-- `shell-name` (optional, default: ``): sets the shell name in the left upper corner of the header
- - example `<dbp-app-shell shell-name="Testpage"></dbp-app-shell>`
-- `shell-subname` (optional, default: ``): sets the shell subname in the left upper corner of the header
- - example `<dbp-app-shell shell-name="Testpage subtitle"></dbp-app-shell>`
- `no-brand` (optional): disables the logo in the right upper corner of the header
- example `<dbp-app-shell no-brand></dbp-app-shell>`
diff --git a/packages/app-shell/src/app-shell.js b/packages/app-shell/src/app-shell.js
index 31b94993..1a8a0b0f 100644
--- a/packages/app-shell/src/app-shell.js
+++ b/packages/app-shell/src/app-shell.js
@@ -68,8 +68,6 @@ export class AppShell extends ScopedElementsMixin(AdapterLitElement) {
this._attrObserver = new MutationObserver(this.onAttributeObserved);
- this.shellName = '';
- this.shellSubname= '';
this.noBrand = false;
this.auth = {};
}
@@ -244,8 +242,6 @@ export class AppShell extends ScopedElementsMixin(AdapterLitElement) {
matomoUrl: { type: String, attribute: "matomo-url" },
matomoSiteId: { type: Number, attribute: "matomo-site-id" },
noWelcomePage: { type: Boolean, attribute: "no-welcome-page" },
- shellName: { type: String, attribute: "shell-name" },
- shellSubname: { type: String, attribute: "shell-subname" },
noBrand: { type: Boolean, attribute: "no-brand" },
gitInfo: { type: String, attribute: "git-info" },
buildUrl: { type: String, attribute: "build-url" },
@@ -891,7 +887,7 @@ export class AppShell extends ScopedElementsMixin(AdapterLitElement) {
</div>
<div class="hd2-left">
<div class="header">
- <slot name="name">${this.shellName}<br>${this.shellSubname}</slot>
+ <slot name="name">Digital Blueprint</slot>
</div>
</div>
<div class="hd2-right">
--
GitLab