From 4f06a324748408a4b9ad35b0178e214f499a1050 Mon Sep 17 00:00:00 2001 From: Christoph Reiter <reiter.christoph@gmail.com> Date: Wed, 18 Dec 2019 14:03:51 +0100 Subject: [PATCH] Remove VPULitElement/VPULitElementJQuery We should try to avoid changing the DOM directly and these helpers go against that. They both just add two lines of code which we can just copy around if needed. --- packages/common/vpu-lit-element-jquery.js | 8 -------- packages/common/vpu-lit-element.js | 7 ------- 2 files changed, 15 deletions(-) delete mode 100644 packages/common/vpu-lit-element-jquery.js delete mode 100644 packages/common/vpu-lit-element.js diff --git a/packages/common/vpu-lit-element-jquery.js b/packages/common/vpu-lit-element-jquery.js deleted file mode 100644 index d1b1ca7b..00000000 --- a/packages/common/vpu-lit-element-jquery.js +++ /dev/null @@ -1,8 +0,0 @@ -import VPULitElement from "./vpu-lit-element"; -import $ from "jquery"; - -export default class VPULitElementJQuery extends VPULitElement { - $(selector) { - return $(this._(selector)); - } -} diff --git a/packages/common/vpu-lit-element.js b/packages/common/vpu-lit-element.js deleted file mode 100644 index 63895435..00000000 --- a/packages/common/vpu-lit-element.js +++ /dev/null @@ -1,7 +0,0 @@ -import {LitElement} from "lit-element"; - -export default class VPULitElement extends LitElement { - _(selector) { - return this.shadowRoot === null ? this.querySelector(selector) : this.shadowRoot.querySelector(selector); - } -} -- GitLab