From 290df8a77520501a96f9709d446fb63beedb528b Mon Sep 17 00:00:00 2001 From: Patrizio Bekerle <patrizio.bekerle@tugraz.at> Date: Thu, 17 Oct 2019 11:02:28 +0200 Subject: [PATCH] Remove Bulma dependency --- .../package.json | 1 - ...owledge-base-web-page-element-view-demo.js | 29 +++++++++---------- ...pu-knowledge-base-web-page-element-view.js | 4 +-- 3 files changed, 15 insertions(+), 19 deletions(-) diff --git a/packages/knowledge-base-web-page-element-view/package.json b/packages/knowledge-base-web-page-element-view/package.json index e0cc14f5..b8823697 100644 --- a/packages/knowledge-base-web-page-element-view/package.json +++ b/packages/knowledge-base-web-page-element-view/package.json @@ -29,7 +29,6 @@ "vpu-common": "file:./vendor/common" }, "dependencies": { - "bulma": "^0.7.5", "i18next": "^17.0.3", "lit-element": "^2.1.0", "lit-html": "^1.1.1", diff --git a/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view-demo.js b/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view-demo.js index be09b9b6..f40e936e 100644 --- a/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view-demo.js +++ b/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view-demo.js @@ -3,7 +3,7 @@ import {css, html, LitElement} from 'lit-element'; import 'vpu-auth'; import './vpu-knowledge-base-web-page-element-view.js'; import * as commonUtils from 'vpu-common/utils'; -import bulmaCSSPath from "bulma/css/bulma.min.css"; +import * as commonStyles from 'vpu-common/styles'; class KnowledgeBaseWebPageElementViewDemo extends LitElement { constructor() { @@ -32,8 +32,21 @@ class KnowledgeBaseWebPageElementViewDemo extends LitElement { static get styles() { // language=css return css` + ${commonStyles.getThemeCSS()} + ${commonStyles.getGeneralCSS()} + h1.title {margin-bottom: 1em;} div.container {margin-bottom: 1.5em;} + + vpu-knowledge-base-web-page-element-view.clean { + --KBBorder: initial; + --KBBorderRadius: initial; + --KBMargin: initial; + --KBPadding: initial; + } + vpu-knowledge-base-web-page-element-view.opt { + --KBBorder: 2px solid blue; + } `; } @@ -47,21 +60,7 @@ class KnowledgeBaseWebPageElementViewDemo extends LitElement { render() { commonUtils.initAssetBaseURL('vpu-knowledge-base-web-page-element-view-src'); - const bulmaCSS = commonUtils.getAssetURL(bulmaCSSPath); return html` - <link rel="stylesheet" href="${bulmaCSS}"> - <style> - vpu-knowledge-base-web-page-element-view.clean { - --KBBorder: initial; - --KBBorderRadius: initial; - --KBMargin: initial; - --KBPadding: initial; - } - vpu-knowledge-base-web-page-element-view.opt { - --KBBorder: 2px solid blue; - } - </style> - <section class="section"> <div class="container"> <h1 class="title">KnowledgeBaseWebPageElementView-Demo</h1> diff --git a/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view.js b/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view.js index 8e437b4e..a4f532c3 100644 --- a/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view.js +++ b/packages/knowledge-base-web-page-element-view/src/vpu-knowledge-base-web-page-element-view.js @@ -5,7 +5,6 @@ import VPULitElement from 'vpu-common/vpu-lit-element' import "vpu-common/vpu-mini-spinner.js"; import * as commonUtils from "vpu-common/utils"; import {unsafeHTML} from 'lit-html/directives/unsafe-html.js'; -import bulmaCSSPath from "bulma/css/bulma.min.css"; /** * KnowledgeBaseWebPageElementView web component @@ -156,9 +155,8 @@ class VPUKnowledgeBaseWebPageElementView extends VPULitElement { render() { commonUtils.initAssetBaseURL('vpu-knowledge-base-web-page-element-view-src'); - const bulmaCSS = commonUtils.getAssetURL(bulmaCSSPath); + return html` - <link rel="stylesheet" href="${bulmaCSS}"> <style> .kb { display: none; -- GitLab