From 2853737ee2b6656c1c1c47dc54abaa578bb5cb23 Mon Sep 17 00:00:00 2001
From: Manuel Kocher <manuel.kocher@tugraz.at>
Date: Mon, 30 Jan 2023 16:02:50 +0100
Subject: [PATCH] Bugfix loading spinner to work with safari 12 again
---
packages/app-shell/src/app-shell.js | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/packages/app-shell/src/app-shell.js b/packages/app-shell/src/app-shell.js
index a286b252..51653a68 100644
--- a/packages/app-shell/src/app-shell.js
+++ b/packages/app-shell/src/app-shell.js
@@ -340,11 +340,14 @@ export class AppShell extends ScopedElementsMixin(DBPLitElement) {
this._updateVisibleRoutes();
const loginStatus = this.auth['login-status'];
+
if (loginStatus !== this._loginStatus) {
console.log('Login status: ' + loginStatus);
}
- this._loginStatus = loginStatus;
+ if (loginStatus !== undefined) {
+ this._loginStatus = loginStatus;
+ }
// Clear the session storage when the user logs out
if (this._loginStatus === 'logging-out') {
@@ -943,13 +946,9 @@ export class AppShell extends ScopedElementsMixin(DBPLitElement) {
// if app is loaded correctly, remove spinner
this.updateComplete.then(() => {
const slot = this.shadowRoot.querySelector('slot:not([name])');
- if (slot) slot.style.display = 'none';
- });
- } else {
- // if app is not loaded correctly, show spinner
- this.updateComplete.then(() => {
- const slot = this.shadowRoot.querySelector('slot:not([name])');
- if (slot) slot.style.display = '';
+
+ // remove for safari 12 support. safari 13+ supports display: none on slots.
+ if (slot) slot.remove();
});
}
--
GitLab