From 2cd25d343afa1511ce1cd76ac74777ad5f15f19e Mon Sep 17 00:00:00 2001
From: Patrizio Bekerle <patrizio@bekerle.com>
Date: Fri, 10 Apr 2020 08:08:34 +0200
Subject: [PATCH] Do refactoring from SignaturePdfUpload to
OfficialSignaturePdfUpload (#4)
---
...ficial-signature-pdf-upload.metadata.json} | 6 ++---
assets/vpu-signature.topic.metadata.json | 2 +-
rollup.config.js | 2 +-
src/i18n/de/translation.json | 2 +-
src/i18n/en/translation.json | 2 +-
...s => vpu-official-signature-pdf-upload.js} | 22 +++++++++----------
test/unit.js | 6 ++---
7 files changed, 21 insertions(+), 21 deletions(-)
rename assets/{vpu-signature-pdf-upload.metadata.json => vpu-official-signature-pdf-upload.metadata.json} (70%)
rename src/{vpu-signature-pdf-upload.js => vpu-official-signature-pdf-upload.js} (89%)
diff --git a/assets/vpu-signature-pdf-upload.metadata.json b/assets/vpu-official-signature-pdf-upload.metadata.json
similarity index 70%
rename from assets/vpu-signature-pdf-upload.metadata.json
rename to assets/vpu-official-signature-pdf-upload.metadata.json
index 47de689..890096c 100644
--- a/assets/vpu-signature-pdf-upload.metadata.json
+++ b/assets/vpu-official-signature-pdf-upload.metadata.json
@@ -1,7 +1,7 @@
{
- "element": "vpu-signature-pdf-upload",
- "module_src": "vpu-signature-pdf-upload.js",
- "routing_name": "pdf-upload",
+ "element": "vpu-official-signature-pdf-upload",
+ "module_src": "vpu-official-signature-pdf-upload.js",
+ "routing_name": "official-pdf-upload",
"name": {
"de": "Amtssignatur aufbringen",
"en": "Officially sign"
diff --git a/assets/vpu-signature.topic.metadata.json b/assets/vpu-signature.topic.metadata.json
index b31df5b..5f421ef 100644
--- a/assets/vpu-signature.topic.metadata.json
+++ b/assets/vpu-signature.topic.metadata.json
@@ -13,7 +13,7 @@
},
"routing_name": "signature",
"activities": [
- {"path": "vpu-signature-pdf-upload.metadata.json"}
+ {"path": "vpu-official-signature-pdf-upload.metadata.json"}
],
"attributes": []
}
\ No newline at end of file
diff --git a/rollup.config.js b/rollup.config.js
index 33ffc03..567a122 100644
--- a/rollup.config.js
+++ b/rollup.config.js
@@ -142,7 +142,7 @@ function getBuildInfo() {
export default {
input: (build != 'test') ? [
'src/vpu-signature.js',
- 'src/vpu-signature-pdf-upload.js',
+ 'src/vpu-official-signature-pdf-upload.js',
] : glob.sync('test/**/*.js'),
output: {
dir: 'dist',
diff --git a/src/i18n/de/translation.json b/src/i18n/de/translation.json
index d1feb9b..008adb4 100644
--- a/src/i18n/de/translation.json
+++ b/src/i18n/de/translation.json
@@ -1,5 +1,5 @@
{
- "pdf-upload": {
+ "official-pdf-upload": {
"upload-field-label": "PDF Dateien zum Signieren hochladen",
"upload-area-text": "Sie können in diesem Bereich PDF Dateien per Drag & Drop oder per Direktauswahl hochladen",
"signed-files-label": "Signierte Dateien",
diff --git a/src/i18n/en/translation.json b/src/i18n/en/translation.json
index 1552c6f..752e914 100644
--- a/src/i18n/en/translation.json
+++ b/src/i18n/en/translation.json
@@ -1,5 +1,5 @@
{
- "pdf-upload": {
+ "official-pdf-upload": {
"upload-field-label": "Upload PDF files to sign",
"upload-area-text": "In this area you can upload PDF files via Drag & Drop or by selecting them directly",
"signed-files-label": "Signed files",
diff --git a/src/vpu-signature-pdf-upload.js b/src/vpu-official-signature-pdf-upload.js
similarity index 89%
rename from src/vpu-signature-pdf-upload.js
rename to src/vpu-official-signature-pdf-upload.js
index a4c863d..56defbf 100644
--- a/src/vpu-signature-pdf-upload.js
+++ b/src/vpu-official-signature-pdf-upload.js
@@ -12,7 +12,7 @@ import 'vpu-file-upload';
const i18n = createI18nInstance();
-class SignaturePdfUpload extends VPUSignatureLitElement {
+class OfficialSignaturePdfUpload extends VPUSignatureLitElement {
constructor() {
super();
this.lang = i18n.language;
@@ -67,7 +67,7 @@ class SignaturePdfUpload extends VPUSignatureLitElement {
onFileUploadStarted(ev) {
console.log(ev);
this.uploadStatusFileName = ev.detail.fileName;
- this.uploadStatusText = i18n.t('pdf-upload.upload-status-file-text', {
+ this.uploadStatusText = i18n.t('official-pdf-upload.upload-status-file-text', {
fileName: ev.detail.fileName,
fileSize: humanFileSize(ev.detail.fileSize, false),
});
@@ -246,7 +246,7 @@ class SignaturePdfUpload extends VPUSignatureLitElement {
return this.signedFiles.map(file => html`
<div class="file">
<a class="is-download"
- title="${i18n.t('pdf-upload.download-file-button-title')}"
+ title="${i18n.t('official-pdf-upload.download-file-button-title')}"
@click="${() => {this.fileDownloadClickHandler(file);}}">
${file.name} (${humanFileSize(file.contentSize)}) <vpu-icon name="download"></vpu-icon></a>
</div>
@@ -258,7 +258,7 @@ class SignaturePdfUpload extends VPUSignatureLitElement {
<div class="file">
<div class="button-box">
<button class="button is-small"
- title="${i18n.t('pdf-upload.re-upload-file-button-title')}"
+ title="${i18n.t('official-pdf-upload.re-upload-file-button-title')}"
@click="${() => {this.fileUploadClickHandler(data.file, id);}}"><vpu-icon name="reload"></vpu-icon></button>
</div>
<div class="info">
@@ -273,10 +273,10 @@ class SignaturePdfUpload extends VPUSignatureLitElement {
return html`
<div class="${classMap({hidden: !this.isLoggedIn() || !this.hasSignaturePermissions()})}">
<div class="field">
- <h2>${i18n.t('pdf-upload.upload-field-label')}</h2>
+ <h2>${i18n.t('official-pdf-upload.upload-field-label')}</h2>
<div class="control">
<vpu-fileupload id="file-upload" lang="${this.lang}" url="${this.signingUrl}" accept="application/pdf"
- text="${i18n.t('pdf-upload.upload-area-text')}" button-label="${i18n.t('pdf-upload.upload-button-label')}"></vpu-fileupload>
+ text="${i18n.t('official-pdf-upload.upload-area-text')}" button-label="${i18n.t('official-pdf-upload.upload-button-label')}"></vpu-fileupload>
</div>
</div>
<div class="field notification is-info ${classMap({hidden: !this.uploadInProgress})}">
@@ -285,25 +285,25 @@ class SignaturePdfUpload extends VPUSignatureLitElement {
${this.uploadStatusText}
</div>
<div class="files-block field ${classMap({hidden: this.signedFilesCount === 0})}">
- <h2>${i18n.t('pdf-upload.signed-files-label')}</h2>
+ <h2>${i18n.t('official-pdf-upload.signed-files-label')}</h2>
<div class="control">
${this.getSignedFilesHtml()}
</div>
</div>
<div class="field ${classMap({hidden: this.signedFilesCount === 0})}">
<div class="control">
- <vpu-button id="zip-download-button" value="${i18n.t('pdf-upload.download-zip-button')}" title="${i18n.t('pdf-upload.download-zip-button-tooltip')}" @click="${this.zipDownloadClickHandler}" type="is-primary"></vpu-button>
+ <vpu-button id="zip-download-button" value="${i18n.t('official-pdf-upload.download-zip-button')}" title="${i18n.t('official-pdf-upload.download-zip-button-tooltip')}" @click="${this.zipDownloadClickHandler}" type="is-primary"></vpu-button>
</div>
</div>
<div class="files-block error-files field ${classMap({hidden: this.errorFilesCount === 0})}">
- <h2 class="error">${i18n.t('pdf-upload.error-files-label')}</h2>
+ <h2 class="error">${i18n.t('official-pdf-upload.error-files-label')}</h2>
<div class="control">
${this.getErrorFilesHtml()}
</div>
</div>
<div class="field ${classMap({hidden: this.errorFilesCount === 0})}">
<div class="control">
- <vpu-button id="re-upload-all-button" ?disabled="${this.uploadInProgress}" value="${i18n.t('pdf-upload.re-upload-all-button')}" title="${i18n.t('pdf-upload.re-upload-all-button-title')}" @click="${this.reUploadAllClickHandler}" type="is-primary"></vpu-button>
+ <vpu-button id="re-upload-all-button" ?disabled="${this.uploadInProgress}" value="${i18n.t('official-pdf-upload.re-upload-all-button')}" title="${i18n.t('official-pdf-upload.re-upload-all-button-title')}" @click="${this.reUploadAllClickHandler}" type="is-primary"></vpu-button>
</div>
</div>
</div>
@@ -317,4 +317,4 @@ class SignaturePdfUpload extends VPUSignatureLitElement {
}
}
-commonUtils.defineCustomElement('vpu-signature-pdf-upload', SignaturePdfUpload);
+commonUtils.defineCustomElement('vpu-official-signature-pdf-upload', OfficialSignaturePdfUpload);
diff --git a/test/unit.js b/test/unit.js
index 654fe70..2b0304c 100644
--- a/test/unit.js
+++ b/test/unit.js
@@ -1,13 +1,13 @@
import {assert} from 'chai';
-import '../src/vpu-signature-pdf-upload';
+import '../src/vpu-official-signature-pdf-upload';
import '../src/vpu-signature.js';
-suite('vpu-signature-pdf-upload basics', () => {
+suite('vpu-official-signature-pdf-upload basics', () => {
let node;
suiteSetup(async () => {
- node = document.createElement('vpu-signature-pdf-upload');
+ node = document.createElement('vpu-official-signature-pdf-upload');
document.body.appendChild(node);
await node.updateComplete;
});
--
GitLab